Add rmw_publisher_count_non_local_matched_subscriptions#358
Open
MiguelCompany wants to merge 1 commit intoros2:rollingfrom
Open
Add rmw_publisher_count_non_local_matched_subscriptions#358MiguelCompany wants to merge 1 commit intoros2:rollingfrom
rmw_publisher_count_non_local_matched_subscriptions#358MiguelCompany wants to merge 1 commit intoros2:rollingfrom
Conversation
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
MiguelCompany
requested review from
ivanpauno,
methylDragon and
wjwwood
as code owners
This was referenced Oct 20, 2023
fujitatomoya
requested changes
Oct 24, 2023
| /** | ||
| * Query the underlying middleware to determine how many non local subscriptions are | ||
| * matched to a given publisher. | ||
| * |
Collaborator
There was a problem hiding this comment.
I think it would be better to define what is local means by here.
Suggested change
| * | |
| * The definition of local means that in the same context. | |
| * |
Collaborator
|
maybe we can discuss this interface for next MW WG. |
Contributor
|
@MiguelCompany Friendly ping. Would you be willing to address @fujitatomoya's feedback? |
Collaborator
|
@MiguelCompany @wjwwood i would like to have a quick chat in next MW WG which is scheduled on 15th.Nov.2023. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds function that returns the number of matched subscriptions that are not in the same context as the publisher.
Part of ros2/rclcpp#2202
full repos file here